gpsbabel.git
7 years agoEssentially revert the skytraq part of PR#286.
Robert Lipe [Thu, 14 Feb 2019 20:34:25 +0000 (14:34 -0600)]
Essentially revert the skytraq part of PR#286.

7 years agoMerge branch 'master' into atoi
GPSBabel [Sat, 22 Dec 2018 18:59:25 +0000 (12:59 -0600)]
Merge branch 'master' into atoi

7 years agoMerge pull request #284 from gpsbabel/cl-cleanups
GPSBabel [Sat, 22 Dec 2018 18:58:16 +0000 (12:58 -0600)]
Merge pull request #284 from gpsbabel/cl-cleanups

CodeLion-inspired and manual cleanups

7 years agoadd support for multiple urls for route headers. (#276)
tsteven4 [Thu, 20 Dec 2018 16:38:22 +0000 (09:38 -0700)]
add support for multiple urls for route headers. (#276)

* add support for multiple urls for route headers.

add support in gpx for gpx/rte/link, gpx/rte/url, gpx/rte/urlname.
add support in gpx for gpx/trk/link, gpx/trk/url, gpx/trk/urlname.

Note that the gpx writer can violate the schema when fprint_xml_chain
is used to echo unrecognized elements from input to output.
This is because the gpx 1.0/1.1 schema requires an xsd:sequence of
elements, i.e. the order of the elements is specified, and any
elements output by fprint_xml_chain won't necessarily be in
the correct order with other elements that are specifically
handled in the gpx writer.

By processing additional gpx elements as listed above on read we
prevent them from causing schema violations on write.  However,
other unrecognized elements can still cause schema violations.

* make common link code common in gpx reader.

7 years agoDon't #include debug
Robert Lipe [Thu, 20 Dec 2018 04:50:06 +0000 (22:50 -0600)]
Don't #include debug

7 years agoA near rewrite of the reader of the stmsdf reader to more effectively parse fields...
Robert Lipe [Thu, 20 Dec 2018 04:24:41 +0000 (22:24 -0600)]
A near rewrite of the reader of the stmsdf reader to more effectively parse fields as QDate,Times,Floats, etc. Still not very readable, but should be more bulletproof for bad input.

7 years agoDon't name params in decls in itracku
Robert Lipe [Thu, 20 Dec 2018 04:21:00 +0000 (22:21 -0600)]
Don't name params in decls in itracku

7 years agoSign extension fix in EasyGPS
Robert Lipe [Thu, 20 Dec 2018 04:20:24 +0000 (22:20 -0600)]
Sign extension fix in EasyGPS

7 years agoRemove xstrrstr and BASE_STRUCT from defs.h
Robert Lipe [Thu, 20 Dec 2018 04:19:40 +0000 (22:19 -0600)]
Remove xstrrstr and BASE_STRUCT from defs.h

7 years agoRemove write-only variable in compegps.
Robert Lipe [Thu, 20 Dec 2018 04:19:05 +0000 (22:19 -0600)]
Remove write-only variable in compegps.

7 years agoDrop some unused method protos from CET.
Robert Lipe [Thu, 20 Dec 2018 04:18:29 +0000 (22:18 -0600)]
Drop some unused method protos from CET.

7 years agoXmlStreamWriter: make single arg methods explicit. Drop unused methods.
Robert Lipe [Thu, 20 Dec 2018 04:15:01 +0000 (22:15 -0600)]
XmlStreamWriter: make single arg methods explicit. Drop unused methods.

7 years agoRemoving scraggling bits of xhtmlent from build files.
Robert Lipe [Wed, 19 Dec 2018 05:44:48 +0000 (23:44 -0600)]
Removing scraggling bits of xhtmlent from build files.

7 years agoRemove (now) unused xhtmlent table.
Robert Lipe [Wed, 19 Dec 2018 05:25:09 +0000 (23:25 -0600)]
Remove (now) unused xhtmlent table.

7 years agoMake types in ggv_bin more safe for 32/64 systems.
Robert Lipe [Wed, 19 Dec 2018 04:56:45 +0000 (22:56 -0600)]
Make types in ggv_bin more safe for 32/64 systems.

7 years agoDefault construct to eliminate warning in geojson
Robert Lipe [Wed, 19 Dec 2018 04:49:13 +0000 (22:49 -0600)]
Default construct to eliminate warning in geojson

7 years agoBuild fix for Cmake/CLion on Mac. Correct handling of frameworks. They're like
Robert Lipe [Wed, 19 Dec 2018 03:52:14 +0000 (21:52 -0600)]
Build fix for Cmake/CLion on Mac. Correct handling of frameworks. They're like
libs, but not...

7 years agoadd cppcheck target to GPSBabel.pro. (#280)
tsteven4 [Fri, 14 Dec 2018 14:24:23 +0000 (07:24 -0700)]
add cppcheck target to GPSBabel.pro. (#280)

* add cppcheck target to GPSBabel.pro.

fix a few cppcheck errors.

* fix a few cppcheck items.

strptime fix is from upstream.

7 years agoWrap (use) of variables in #defines.
Robert Lipe [Tue, 4 Dec 2018 06:47:36 +0000 (00:47 -0600)]
Wrap (use) of variables in #defines.

7 years agoWarning fix in raymarine
Robert Lipe [Mon, 3 Dec 2018 06:47:50 +0000 (00:47 -0600)]
Warning fix in raymarine

7 years agoWarning fix in locus
Robert Lipe [Mon, 3 Dec 2018 06:46:02 +0000 (00:46 -0600)]
Warning fix in locus

7 years agoFix warning in maggeo
Robert Lipe [Mon, 3 Dec 2018 06:43:29 +0000 (00:43 -0600)]
Fix warning in maggeo

7 years agoWarning fixes in jeeps: move use closer to initialization so that the
Robert Lipe [Mon, 3 Dec 2018 06:37:29 +0000 (00:37 -0600)]
Warning fixes in jeeps: move use closer to initialization so that the
test of device is effective, don't set locals before return.

7 years agoTame string formatting warning in libusb.
Robert Lipe [Mon, 3 Dec 2018 06:34:13 +0000 (00:34 -0600)]
Tame string formatting warning in libusb.

7 years agoRemove unneeded const qualifier on pass-by-value types.
Robert Lipe [Mon, 3 Dec 2018 06:16:39 +0000 (00:16 -0600)]
Remove unneeded const qualifier on pass-by-value types.

7 years agoReplace size() == 0 with empty() when more readable.
Robert Lipe [Mon, 3 Dec 2018 06:05:08 +0000 (00:05 -0600)]
Replace size() == 0 with empty() when more readable.

7 years agoConst-ipate jeeps function signature. (Yeah, coz THAT makes that API beautiful...)
Robert Lipe [Mon, 3 Dec 2018 05:58:26 +0000 (23:58 -0600)]
Const-ipate jeeps function signature. (Yeah, coz THAT makes that API beautiful...)

7 years agoAutomated cleanups for passing by reference and fixing pointer ownership on calls.
Robert Lipe [Mon, 3 Dec 2018 05:50:03 +0000 (23:50 -0600)]
Automated cleanups for passing by reference and fixing pointer ownership on calls.

7 years agoModernize loop iterators to walk arrays and containes instead of independently
Robert Lipe [Mon, 3 Dec 2018 05:45:25 +0000 (23:45 -0600)]
Modernize loop iterators to walk arrays and containes instead of independently
maintained constants.

7 years agoModernize C style explicit (void) in decls to (), eliminate return
Robert Lipe [Mon, 3 Dec 2018 05:41:22 +0000 (23:41 -0600)]
Modernize C style explicit (void) in decls to (), eliminate return
at end of bunction bodies.

7 years agoModernize bool use of true/false.
Robert Lipe [Mon, 3 Dec 2018 05:35:53 +0000 (23:35 -0600)]
Modernize bool use of true/false.

7 years agoMake prototype arg names match function arg names.
Robert Lipe [Mon, 3 Dec 2018 05:34:28 +0000 (23:34 -0600)]
Make prototype arg names match function arg names.

7 years agoPick up a few old NULL->nullptr conversions that are stuck inside __APPLE that
Robert Lipe [Mon, 3 Dec 2018 04:49:33 +0000 (22:49 -0600)]
Pick up a few old NULL->nullptr conversions that are stuck inside __APPLE that
tsteven4 dodged around since he couldn't confirm.

7 years agoFor single argument ctors, mark type explicit.
Robert Lipe [Mon, 3 Dec 2018 04:45:41 +0000 (22:45 -0600)]
For single argument ctors, mark type explicit.

7 years agoIf there's only one argument in a ctor, mark it explicit to make it less
Robert Lipe [Mon, 3 Dec 2018 04:39:59 +0000 (22:39 -0600)]
If there's only one argument in a ctor, mark it explicit to make it less
easy to fall into implicit conversions.

7 years agoDiff and Terrain in geocaches are integers internally.
Robert Lipe [Mon, 3 Dec 2018 04:35:22 +0000 (22:35 -0600)]
Diff and Terrain in geocaches are integers internally.

7 years agogenerate html coverage reports. (#281)
tsteven4 [Sun, 2 Dec 2018 23:52:22 +0000 (16:52 -0700)]
generate html coverage reports. (#281)

* generate html coverage reports.

* tweak coverage recipe.

7 years agoremove obsolete msvc workarounds. (#278)
tsteven4 [Sat, 1 Dec 2018 15:03:37 +0000 (08:03 -0700)]
remove obsolete msvc workarounds. (#278)

msvc 2012 and earlier are not supported.
They didn't support c++14 anyway which we currently require.

7 years agouse QThread::usleep instead of our own function. (#277)
tsteven4 [Wed, 28 Nov 2018 14:00:10 +0000 (07:00 -0700)]
use QThread::usleep instead of our own function. (#277)

Our test suite doesn't test sleep, but the nmea pause option
can be used on write to verify functionality interactively.

7 years agoobsolete DEBUG_MEM (#279)
tsteven4 [Wed, 28 Nov 2018 01:48:17 +0000 (18:48 -0700)]
obsolete DEBUG_MEM (#279)

7 years agosimplify conversion from utm. (#275)
tsteven4 [Tue, 27 Nov 2018 23:37:49 +0000 (16:37 -0700)]
simplify conversion from utm. (#275)

* simplify conversion from utm.

add test cases for Norway and Svalbard exceptions.

* Correct bug in computing latitude band X.

enhance test to cover exceptional width of band X.

7 years agoupdate shapelib to 1.4.1 (#274)
tsteven4 [Sat, 24 Nov 2018 18:59:45 +0000 (11:59 -0700)]
update shapelib to 1.4.1 (#274)

7 years agoenhance sort filter for rtes & trks. (#273)
tsteven4 [Mon, 19 Nov 2018 18:54:46 +0000 (11:54 -0700)]
enhance sort filter for rtes & trks. (#273)

7 years agouse bool, true, false. (#272)
tsteven4 [Sat, 17 Nov 2018 22:06:31 +0000 (15:06 -0700)]
use bool, true, false. (#272)

7 years agoadd msvc2017 builds to appveyor. (#270)
tsteven4 [Wed, 14 Nov 2018 16:41:06 +0000 (09:41 -0700)]
add msvc2017 builds to appveyor. (#270)

7 years agoupdate docker build script to use latest bionic. (#269)
tsteven4 [Wed, 14 Nov 2018 15:42:28 +0000 (08:42 -0700)]
update docker build script to use latest bionic. (#269)

7 years agoMerge pull request #266 from tsteven4/clazy1
tsteven4 [Wed, 14 Nov 2018 15:09:23 +0000 (08:09 -0700)]
Merge pull request #266 from tsteven4/clazy1

Incorporate improvements found by Qt oriented code checker clazy

7 years agoMerge pull request #267 from gpsbabel/gpsbabel-patch-2
GPSBabel [Wed, 14 Nov 2018 02:42:14 +0000 (20:42 -0600)]
Merge pull request #267 from gpsbabel/gpsbabel-patch-2

Remove leftover code from 'adding class' change

7 years agoRemove leftover code from 'adding class' change
GPSBabel [Tue, 13 Nov 2018 21:07:09 +0000 (15:07 -0600)]
Remove leftover code from 'adding class' change

As tsteven4 points out, No reasing to move is_internal to local and back

7 years agofix clazy detected 'use isEmpty() instead'
tsteven4 [Tue, 13 Nov 2018 15:53:34 +0000 (08:53 -0700)]
fix clazy detected 'use isEmpty() instead'

this is from -Wclazy-isempty-vs-count

7 years agofix clazy detected 'Use *Ref() instead'
tsteven4 [Tue, 13 Nov 2018 15:30:46 +0000 (08:30 -0700)]
fix clazy detected 'Use *Ref() instead'

These are from -Wclazy-qstring-ref, and were automatically fixed.

7 years agofix clazy detected 'unused *'
tsteven4 [Tue, 13 Nov 2018 15:18:09 +0000 (08:18 -0700)]
fix clazy detected 'unused *'

these are from -Wclazy-unused-non-trivial-variable

7 years agofix clazy detected 'allocating an unneeded temporary container'
tsteven4 [Tue, 13 Nov 2018 14:59:10 +0000 (07:59 -0700)]
fix clazy detected 'allocating an unneeded temporary container'

these are from -Wclazy-container-anti-pattern

Also, consistently use range based for loops in csv_util.cc

7 years agofix clazy detected 'c++11 range-loop might detach Qt container'
tsteven4 [Mon, 12 Nov 2018 16:13:28 +0000 (09:13 -0700)]
fix clazy detected 'c++11 range-loop might detach Qt container'

these are from -Wclazy-range-loop

7 years agofix clazy detected 'Use multi-arg instead'
tsteven4 [Mon, 12 Nov 2018 15:12:21 +0000 (08:12 -0700)]
fix clazy detected 'Use multi-arg instead'

these are from -Wclazy-qstring-arg

7 years agoupdate travis for xenial (#265)
tsteven4 [Sun, 4 Nov 2018 17:36:58 +0000 (10:36 -0700)]
update travis for xenial (#265)

* update travis to use xenial.

add new travis target to build on xenial.
switch travis coverage generation to xenial.
update codacy upload tool for compatibility with newer java on xenial.

* fix gcov issues with "cannot open notes file"

7 years agosupport kml 2.3 track element. (#264)
tsteven4 [Fri, 2 Nov 2018 13:55:31 +0000 (07:55 -0600)]
support kml 2.3 track element. (#264)

* support kml 2.3 track element.

relax ordering requirement for gx:Track when and
coord children.

* fix kml includes and indentation.

7 years agoMerge pull request #261 from gpsbabel/gpsbabel-patch-2
GPSBabel [Fri, 19 Oct 2018 21:30:04 +0000 (16:30 -0500)]
Merge pull request #261 from gpsbabel/gpsbabel-patch-2

Update dependencies, notably for <optional>

7 years agoReplace queues with Qlist in session handling. (#263)
tsteven4 [Fri, 19 Oct 2018 12:13:51 +0000 (06:13 -0600)]
Replace queues with Qlist in session handling. (#263)

session tracks a possible series of input formats and input filenames.

7 years agoMerge pull request #262 from tsteven4/tcache
tsteven4 [Tue, 16 Oct 2018 16:21:00 +0000 (10:21 -0600)]
Merge pull request #262 from tsteven4/tcache

extend travis mac cache timeout.

7 years agoextend travis mac cache timeout.
tsteven4 [Tue, 16 Oct 2018 15:21:22 +0000 (09:21 -0600)]
extend travis mac cache timeout.

7 years agoMerge pull request #260 from tsteven4/cpp14_msvc
tsteven4 [Tue, 16 Oct 2018 13:00:54 +0000 (07:00 -0600)]
Merge pull request #260 from tsteven4/cpp14_msvc

move to c++14 standard.

7 years agoMerge pull request #259 from tsteven4/queue_bye_bye
GPSBabel [Tue, 16 Oct 2018 05:54:13 +0000 (00:54 -0500)]
Merge pull request #259 from tsteven4/queue_bye_bye

eliminate queues in csv style handling.

7 years agoUpdate dependencies, notably for <optional>
GPSBabel [Tue, 16 Oct 2018 05:22:42 +0000 (00:22 -0500)]
Update dependencies, notably for <optional>

7 years agoMerge pull request #256 from tsteven4/rpath
tsteven4 [Tue, 16 Oct 2018 02:14:44 +0000 (20:14 -0600)]
Merge pull request #256 from tsteven4/rpath

have configure conditionally set rpath.

7 years agomove to c++14 standard.
tsteven4 [Tue, 16 Oct 2018 01:26:53 +0000 (19:26 -0600)]
move to c++14 standard.

7 years agoeliminate queues in csv style handling.
tsteven4 [Mon, 15 Oct 2018 17:00:54 +0000 (11:00 -0600)]
eliminate queues in csv style handling.

also:
fix bug with style option encoding.
pass some parameters by const reference.
eliminate some unused time fiddling.

7 years agoMerge pull request #258 from tsteven4/sortbug
tsteven4 [Thu, 11 Oct 2018 18:40:19 +0000 (12:40 -0600)]
Merge pull request #258 from tsteven4/sortbug

correct sort filter time option to use msecs.

7 years agocorrect sort filter time option to use msecs.
tsteven4 [Thu, 11 Oct 2018 17:28:41 +0000 (11:28 -0600)]
correct sort filter time option to use msecs.

7 years agouse consistent whitespace in configure comments.
tsteven4 [Tue, 9 Oct 2018 19:42:37 +0000 (13:42 -0600)]
use consistent whitespace in configure comments.

7 years agohave configure conditionally set rpath.
tsteven4 [Tue, 9 Oct 2018 18:47:42 +0000 (12:47 -0600)]
have configure conditionally set rpath.

this may be necessary when using a Qt installation
that was not provided by the system.

7 years agoMerge pull request #255 from gpsbabel/parallel
GPSBabel [Tue, 9 Oct 2018 05:45:25 +0000 (00:45 -0500)]
Merge pull request #255 from gpsbabel/parallel

Parallelize CLI and GUI make.

7 years agoParallelize CLI and GUI make. testo and vtesto are harder.
Robert Lipe [Tue, 9 Oct 2018 04:57:28 +0000 (04:57 +0000)]
Parallelize CLI and GUI make. testo and vtesto are harder.

7 years agoMerge pull request #254 from gpsbabel/tweaks
GPSBabel [Tue, 9 Oct 2018 04:20:55 +0000 (23:20 -0500)]
Merge pull request #254 from gpsbabel/tweaks

Move more xcsv processing into QStrings. Fewer conversions

7 years agoAllow string to be modified during parse. Ugh.
Robert Lipe [Tue, 9 Oct 2018 03:27:05 +0000 (03:27 +0000)]
Allow string to be modified during parse. Ugh.

7 years agoLet xcsv parser keep QStrings up for one more level.
Robert Lipe [Mon, 8 Oct 2018 23:20:45 +0000 (18:20 -0500)]
Let xcsv parser keep QStrings up for one more level.

7 years agoPush QStrings -> char * conversions down one more level.
Robert Lipe [Mon, 8 Oct 2018 23:17:34 +0000 (18:17 -0500)]
Push QStrings -> char * conversions down one more level.

7 years agoMerge pull request #253 from gpsbabel/tweaks
GPSBabel [Mon, 8 Oct 2018 23:14:58 +0000 (18:14 -0500)]
Merge pull request #253 from gpsbabel/tweaks

Find gsed when doing a tools/docfix on a Mac populated by Homebrew: G…

7 years agoFind gsed when doing a tools/docfix on a Mac populated by Homebrew: GNU sed is /usr...
Robert Lipe [Mon, 8 Oct 2018 19:21:04 +0000 (14:21 -0500)]
Find gsed when doing a tools/docfix on a Mac populated by Homebrew: GNU sed is /usr/local/bin/

7 years agoMerge pull request #252 from gpsbabel/tweaks
GPSBabel [Mon, 8 Oct 2018 19:20:31 +0000 (14:20 -0500)]
Merge pull request #252 from gpsbabel/tweaks

Find gsed when doing a tools/docfix on a Mac populated by Homebrew: GNU sed is /usr/local/bin/

7 years agoMerge pull request #249 from codacy-badger/codacy-badge
GPSBabel [Sat, 6 Oct 2018 04:24:14 +0000 (23:24 -0500)]
Merge pull request #249 from codacy-badger/codacy-badge

Add a Codacy badge to README.md

7 years agoAdd codacy badges to Github README.md
GPSBabel [Fri, 14 Sep 2018 21:05:48 +0000 (16:05 -0500)]
Add codacy badges to Github README.md

7 years agoAdd Codacy badge
The Codacy Badger [Fri, 14 Sep 2018 20:55:52 +0000 (20:55 +0000)]
Add Codacy badge

7 years agoMerge pull request #246 from tsteven4/trackdata
tsteven4 [Sat, 1 Sep 2018 12:52:27 +0000 (06:52 -0600)]
Merge pull request #246 from tsteven4/trackdata

introduce optional class

7 years agointroduce optional class
tsteven4 [Thu, 30 Aug 2018 16:36:07 +0000 (10:36 -0600)]
introduce optional class

for things that may or may not have a value.
demonstrate usage with computed_trkdata.

7 years agoMerge pull request #245 from tsteven4/exif2
tsteven4 [Sat, 25 Aug 2018 22:37:27 +0000 (16:37 -0600)]
Merge pull request #245 from tsteven4/exif2

a few exif cleanups.

7 years agoa few exif cleanups.
tsteven4 [Sat, 25 Aug 2018 21:17:03 +0000 (15:17 -0600)]
a few exif cleanups.

7 years agoMerge pull request #230 from tsteven4/bng
tsteven4 [Thu, 23 Aug 2018 00:22:25 +0000 (18:22 -0600)]
Merge pull request #230 from tsteven4/bng

allow unicsv bng input to use all numeric grid references.

7 years agotweak unicsv bng documentation thanks Hornbydd.
tsteven4 [Wed, 22 Aug 2018 23:51:34 +0000 (17:51 -0600)]
tweak unicsv bng documentation thanks Hornbydd.

7 years agoMerge pull request #238 from tsteven4/exif
tsteven4 [Wed, 22 Aug 2018 21:27:44 +0000 (15:27 -0600)]
Merge pull request #238 from tsteven4/exif

update exif format replacing queues, legacy time_t, tm, localtime, gmtime with Qt classes.
enhance exif rational number approximation using continued fractions.
support uncompressed thumbnails on write.
make debug support dynamic based on debug level instead of a conditional compile.
enhance exif test for write.

7 years agoadd exif support for uncompressed thumbnails.
tsteven4 [Wed, 22 Aug 2018 15:37:13 +0000 (09:37 -0600)]
add exif support for uncompressed thumbnails.

7 years agofix exif dynamic debug omissions.
tsteven4 [Wed, 22 Aug 2018 00:03:43 +0000 (18:03 -0600)]
fix exif dynamic debug omissions.

7 years agofix exif warnings.
tsteven4 [Tue, 21 Aug 2018 21:05:29 +0000 (15:05 -0600)]
fix exif warnings.

7 years agoreplace legacy time handling in exif.
tsteven4 [Tue, 21 Aug 2018 18:09:00 +0000 (12:09 -0600)]
replace legacy time handling in exif.

also add support of exif OffsetTime* tags.

7 years agominor fixes for exif.
tsteven4 [Sun, 19 Aug 2018 22:43:51 +0000 (16:43 -0600)]
minor fixes for exif.

7 years agouse QVariant to store exif tag data.
tsteven4 [Sun, 19 Aug 2018 22:03:50 +0000 (16:03 -0600)]
use QVariant to store exif tag data.

enhance exif debug capability.

7 years agouse continued fractions to create TIFF RATIONAL types.
tsteven4 [Sat, 18 Aug 2018 18:50:07 +0000 (12:50 -0600)]
use continued fractions to create TIFF RATIONAL types.

some references were regenerated as the new algorithm
can generate different values for the RATIONAL numerator
and denominator, in this case 0.0 -> 0/INT32_MAX.

7 years agoimprovements to exif format.
tsteven4 [Thu, 16 Aug 2018 23:53:13 +0000 (17:53 -0600)]
improvements to exif format.

fix bugs with rational types including greatest common divisor.
turn off assertions for release builds in GPSBabel.pro.
clean up exif.

7 years agotweak endian routines for consistency. (#242)
tsteven4 [Wed, 8 Aug 2018 14:31:19 +0000 (08:31 -0600)]
tweak endian routines for consistency. (#242)

align util routeines with prototypes using readability-inconsistent-declaration-parameter-name.

7 years agoeliminate queues in inifile. (#239)
tsteven4 [Thu, 2 Aug 2018 01:21:18 +0000 (19:21 -0600)]
eliminate queues in inifile. (#239)

* eliminate queues in inifile replacing them with QHashs

* replace use of gbfile in inifile with QTextStream